eric-maynard commented on code in PR #2122:
URL: https://github.com/apache/polaris/pull/2122#discussion_r2216898071
##########
plugins/spark/v3.5/spark/src/main/java/org/apache/polaris/spark/PolarisSparkCatalog.java:
##########
@@ -83,9 +83,24 @@ public Table createTable(
throws TableAlreadyExistsException, NoSuchNamespaceException {
try {
String format = properties.get(PolarisCatalogUtils.TABLE_PROVIDER_KEY);
+
+ String baseLocation;
+ // Extract the base table location from the spark properties.
+ // Spark pass the table base location either with the
+ // TableCatalog.PROP_LOCATION key, or with "path" key if created
+ // with the path option.
+ if (properties.get(TableCatalog.PROP_LOCATION) != null) {
Review Comment:
nit: If location and path are both set, it might be worth a debug log
explaining that location is taking precedence
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
