danielhumanmod commented on code in PR #2003:
URL: https://github.com/apache/polaris/pull/2003#discussion_r2187874579
##########
service/common/src/main/java/org/apache/polaris/service/task/TableCleanupTaskHandler.java:
##########
@@ -188,6 +193,9 @@ private Stream<TaskEntity> getManifestTaskStream(
.withData(
new ManifestFileCleanupTaskHandler.ManifestCleanupTask(
tableEntity.getTableIdentifier(),
TaskUtils.encodeManifestFile(mf)))
+ .withLastAttemptExecutorId(executorId)
+ .withAttemptCount(1)
Review Comment:
@adnanhemani continue [previous
discussion](https://github.com/apache/polaris/pull/1585/files#r2122664565)
here:
> How can we assume this?
This new task (`ManifestFileCleanupTask`) is created by the current task
(`TableCleanupTask`) and will be executed immediately at the end of it.
Since it’s its first execution, we set the attemptCount to 1 here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
