danielhumanmod commented on code in PR #2003:
URL: https://github.com/apache/polaris/pull/2003#discussion_r2187873330
##########
runtime/service/src/test/java/org/apache/polaris/service/quarkus/task/TableCleanupTaskHandlerTest.java:
##########
@@ -147,6 +151,8 @@ public void testTableCleanup() throws IOException {
handler.handleTask(task, callContext);
+ timeSource.add(Duration.ofMinutes(10));
Review Comment:
@adnanhemani continue the previous comment here:
> Can you explain this further - I'm not sure why the tests need this 10m
jump? Is it so that tasks are "recovered" by the Quarkus Scheduled method?
`metaStoreManager.loadTasks` fetches available tasks from the metastore —
meaning tasks that are either not leased by any executor or whose lease has
already timed out (after 5 minutes).
In this test, the new tasks are created and not executed by its parent task,
so to ensure these tasks are fetched, we need to simulate a time gap longer
than 5 minutes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
