dimas-b commented on code in PR #1894:
URL: https://github.com/apache/polaris/pull/1894#discussion_r2145503765
##########
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##########
@@ -83,6 +83,7 @@ public static void enforceFeatureEnabledOrThrow(
.defaultValue(false)
.buildFeatureConfiguration();
+ @SuppressWarnings("deprecation")
Review Comment:
My take on this: we should rather remove deprecation from
`catalogConfigUnsafe()` and file issues to remove support for those legacy
properties. The method itself has a valid use case in Polaris code, which is
specifically to support migration from old config names to new name, so the
method itself is not conceptually "deprecated".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
