adutra commented on code in PR #1894:
URL: https://github.com/apache/polaris/pull/1894#discussion_r2145494706
##########
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##########
@@ -83,6 +83,7 @@ public static void enforceFeatureEnabledOrThrow(
.defaultValue(false)
.buildFeatureConfiguration();
+ @SuppressWarnings("deprecation")
Review Comment:
Thanks for the link I didn't know there was a previous conversation on this
topic.
That said, I rather disagree: the annotation is valuable mainly for
consumers of the API, and especially when it's well documented in terms of when
it was deprecated, when it will be removed and how to replace it.
Here, we own both the source of the deprecation warnings (the
`catalogConfigUnsafe` method) and the call sites where the deprecation warnings
are triggered (in `FeatureConfiguration` class): IOW, keeping the warnings
around is not useful for Polaris devs.
And there is no risk of "forgetting" to update `FeatureConfiguration` later
on: as soon as we remove the deprecated method, the `FeatureConfiguration`
class wouldn't compile anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
