eric-maynard commented on code in PR #1840:
URL: https://github.com/apache/polaris/pull/1840#discussion_r2145475356
##########
polaris-core/src/main/java/org/apache/polaris/core/secrets/UserSecretReference.java:
##########
@@ -88,8 +88,7 @@ public UserSecretReference(
*/
@JsonIgnore
public String getUserSecretManagerTypeFromUrn() {
- // TODO: Add better/standardized parsing and validation of URN syntax
- return urn.split(":")[2];
+ return UserSecretReferenceUrnHelper.getSecretManagerType(urn);
Review Comment:
Yeah, I thinking mixing static and nonstatic methods is fine (and an
intended feature of the language, as opposed to e.g. Scala where we must
separate statics into an object and nonstatics into a class). If it keeps the
related logic together without making that class too huge, let's try it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
