eric-maynard commented on code in PR #1840:
URL: https://github.com/apache/polaris/pull/1840#discussion_r2140904240
##########
polaris-core/src/main/java/org/apache/polaris/core/secrets/UnsafeInMemorySecretsManager.java:
##########
@@ -73,9 +73,9 @@ public UserSecretReference writeSecret(
String secretUrn;
for (int secretOrdinal = 0; ; ++secretOrdinal) {
+ String typeSpecificIdentifier = forEntity.getId() + ":" + secretOrdinal;
secretUrn =
- String.format(
- "urn:polaris-secret:unsafe-in-memory:%d:%d", forEntity.getId(),
secretOrdinal);
+ UserSecretReferenceUrnHelper.buildUrn(SECRET_MANAGER_TYPE,
typeSpecificIdentifier);
Review Comment:
Can we not just add `buildUrn` or something like it to `UserSecretsManager`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
