adutra commented on code in PR #1884:
URL: https://github.com/apache/polaris/pull/1884#discussion_r2144463180


##########
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogAdapter.java:
##########
@@ -240,7 +242,11 @@ public Response listNamespaces(
 
   @Override
   public Response loadNamespaceMetadata(
-      String prefix, String namespace, RealmContext realmContext, 
SecurityContext securityContext) {
+      String prefix,
+      String namespace,
+      HttpHeaders httpHeaders,

Review Comment:
   I agree that we need to weigh the pros and cons of each approach. The method 
signatures are becoming quite big, while components like `HttpHeaders`, 
`SecurityContext` (and `RealmContext`) are all injectable. Quarkus lists all 
context objects that are injectable here: 
https://quarkus.io/guides/rest#accessing-context-objects.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to