dimas-b commented on code in PR #1884:
URL: https://github.com/apache/polaris/pull/1884#discussion_r2144133916
##########
api/management-model/build.gradle.kts:
##########
@@ -70,3 +70,5 @@ sourceSets {
tasks.named("javadoc") { dependsOn("jandex") }
tasks.named("processResources") { dependsOn("openApiGenerate") }
+
+tasks.named("openApiGenerate") { outputs.cacheIf { false } }
Review Comment:
is there any particular reason for this?
##########
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogAdapter.java:
##########
@@ -240,7 +242,11 @@ public Response listNamespaces(
@Override
public Response loadNamespaceMetadata(
- String prefix, String namespace, RealmContext realmContext,
SecurityContext securityContext) {
+ String prefix,
+ String namespace,
+ HttpHeaders httpHeaders,
Review Comment:
WDYT about using a filter plus a request-scoped bean for passing headers to
implementation classes?
From my POV that approach:
* Keeps method parameter tuples narrowed down to what is defined in the API
* Affects only the code that needs to know headers
* Can be switched on/off in specific builds / deployments without affecting
the main codebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
