eric-maynard commented on code in PR #1838:
URL: https://github.com/apache/polaris/pull/1838#discussion_r2139125723
##########
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##########
@@ -775,14 +771,10 @@ public List<Namespace> listNamespaces() {
@Override
public List<Namespace> listNamespaces(Namespace namespace) throws
NoSuchNamespaceException {
- return listNamespaces(namespace, PageToken.readEverything()).items;
- }
-
- public Page<Namespace> listNamespaces(Namespace namespace, String pageToken,
Integer pageSize) {
- return listNamespaces(namespace, buildPageToken(pageToken, pageSize));
+ return listNamespaces(namespace, PageToken.readEverything()).items();
}
- private Page<Namespace> listNamespaces(Namespace namespace, PageToken
pageToken)
+ public Page<Namespace> listNamespaces(Namespace namespace, PageToken
pageToken)
Review Comment:
@VisibleForTesting?
##########
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##########
@@ -775,14 +771,10 @@ public List<Namespace> listNamespaces() {
@Override
public List<Namespace> listNamespaces(Namespace namespace) throws
NoSuchNamespaceException {
- return listNamespaces(namespace, PageToken.readEverything()).items;
- }
-
- public Page<Namespace> listNamespaces(Namespace namespace, String pageToken,
Integer pageSize) {
- return listNamespaces(namespace, buildPageToken(pageToken, pageSize));
+ return listNamespaces(namespace, PageToken.readEverything()).items();
}
- private Page<Namespace> listNamespaces(Namespace namespace, PageToken
pageToken)
+ public Page<Namespace> listNamespaces(Namespace namespace, PageToken
pageToken)
Review Comment:
`@VisibleForTesting`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
