dimas-b commented on code in PR #1838: URL: https://github.com/apache/polaris/pull/1838#discussion_r2138522313
########## polaris-core/src/main/java/org/apache/polaris/core/persistence/pagination/PageTokenUtil.java: ########## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.polaris.core.persistence.pagination; + +import static com.google.api.client.util.Preconditions.checkArgument; + +import jakarta.annotation.Nullable; +import java.util.Optional; + +public final class PageTokenUtil { + + private PageTokenUtil() {} + + public static PageRequest decodePageRequest( + @Nullable String requestedPageToken, @Nullable Integer requestedPageSize) { + int pageSize; + String token = null; + if (requestedPageToken != null) { + int idx = requestedPageToken.indexOf(':'); Review Comment: I'll keep the propagation of the previous page size into the next request via the page token. I think doing that is reasonable to maintain better alignment with the REST API spec. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
