fabio-rizzo-01 commented on PR #1596: URL: https://github.com/apache/polaris/pull/1596#issuecomment-2958274275
> Thanks @fabio-rizzo-01 for doing this! +1 on using annotation `PolarisImmutable`. I understand the push to use PolarisImmutable, but I've identified some issues with its implementation: Our object hierarchy consists of Core -> Base -> Entity -> Catalog, with each class extending the previous one. Applying PolarisImmutable to Core and Base would result in two new immutable classes, both of which are final. This prevents further extension of the immutable Base class, disrupting our current hierarchy. While there are workarounds, they would necessitate significant code changes, which I believe should be minimized in this part of the repository. @snazy @singhpk234 @flyrain -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
