eric-maynard commented on PR #1596: URL: https://github.com/apache/polaris/pull/1596#issuecomment-2887317455
Personally I'm fine with you not using `@PolarisImmutable` -- I still haven't figured out why we need that or why my IDE so often doesn't seem to like it: <img width="400" alt="Screenshot 2025-05-16 at 10 34 35 AM" src="https://github.com/user-attachments/assets/7ccb63af-444b-4905-9006-0a1a7e182f23"; /> But I do think this PR makes quite a few changes, such as those to `TransactionalMetaStoreManagerImpl.java`, which could be reduced or elimated. For example, does the method `setGrantRecordsVersion` really need to go away? If it does, can we implement a cloning method like `withGrantRecordsVersion`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
