flyrain commented on code in PR #1783:
URL: https://github.com/apache/polaris/pull/1783#discussion_r2124902721


##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/PolarisMetaStoreManager.java:
##########
@@ -307,7 +308,10 @@ EntityResult loadEntity(
    */
   @Nonnull
   EntitiesResult loadTasks(
-      @Nonnull PolarisCallContext callCtx, String executorId, PageToken 
pageToken);
+      @Nonnull PolarisCallContext callCtx,

Review Comment:
   +1 on using `CallContext`. More boardly, I'd consider consolidating 
`CallContext` and `PolarisCallContext` into one class. Any concerns? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to