gh-yzou commented on code in PR #1783:
URL: https://github.com/apache/polaris/pull/1783#discussion_r2124496840
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/PolarisMetaStoreManager.java:
##########
@@ -307,7 +308,10 @@ EntityResult loadEntity(
*/
@Nonnull
EntitiesResult loadTasks(
- @Nonnull PolarisCallContext callCtx, String executorId, PageToken
pageToken);
+ @Nonnull PolarisCallContext callCtx,
Review Comment:
Yeah, I though about this also, then i was thinking about shall we be more
consistent with the APIs in the interface, since all other APIs doesn't take
CallContext, but PolarisCallContext in. @dimas-b @flyrain are you OK to just
pass the whole CallContext in for this API?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
