snazy commented on code in PR #1532:
URL: https://github.com/apache/polaris/pull/1532#discussion_r2100992299
##########
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##########
@@ -2590,4 +2574,11 @@ private PageToken buildPageToken(@Nullable String
tokenString, @Nullable Integer
return PageToken.build(tokenString, pageSize);
}
}
+
+ static final FeatureConfiguration<Boolean>
INITIALIZE_DEFAULT_CATALOG_FILEIO_FOR_TEST =
+ PolarisConfiguration.<Boolean>builder()
+ .key("INITIALIZE_DEFAULT_CATALOG_FILEIO_FOR_TEST")
+ .defaultValue(false)
+ .description("")
+ .buildFeatureConfiguration();
Review Comment:
Deleting a comment is not the right way - it _completely_ changes the
history of these messages!
You asked to move it back out of `FeaturesConfiguration` into the class
where it was before - and that is EXACTLY what happened. So I seriously ask you
to not bring up wrong accusations & personal offenses!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
