flyrain commented on code in PR #1532:
URL: https://github.com/apache/polaris/pull/1532#discussion_r2100976580
##########
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##########
@@ -2590,4 +2574,11 @@ private PageToken buildPageToken(@Nullable String
tokenString, @Nullable Integer
return PageToken.build(tokenString, pageSize);
}
}
+
+ static final FeatureConfiguration<Boolean>
INITIALIZE_DEFAULT_CATALOG_FILEIO_FOR_TEST =
+ PolarisConfiguration.<Boolean>builder()
+ .key("INITIALIZE_DEFAULT_CATALOG_FILEIO_FOR_TEST")
+ .defaultValue(false)
+ .description("")
+ .buildFeatureConfiguration();
Review Comment:
Deleted my last comment. The part of reason to remove my -1 on this PR is
based on the reverting of INITIALIZE_DEFAULT_CATALOG_FILEIO_FOR_TEST related
change in this PR, which @snazy agreed on in ML. Obviously, it was still here.
Anyway, we can fix forward. I truly hope the community works as a team with
good will and help each other.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
