dimas-b commented on code in PR #1557:
URL: https://github.com/apache/polaris/pull/1557#discussion_r2085798458
##########
polaris-core/src/test/java/org/apache/polaris/service/storage/PolarisConfigurationStoreTest.java:
##########
@@ -75,7 +75,7 @@ public void testConfigsCanBeCastedFromString() {
public void testInvalidCastThrowsException() {
// Bool not included because Boolean.valueOf turns non-boolean strings to
false
List<PolarisConfiguration<?>> configs =
- List.of(buildConfig("int", 12), buildConfig("long", 34L),
buildConfig("double", 5.6D));
+ List.of(buildConfig("int2", 12), buildConfig("long2", 34L),
buildConfig("double2", 5.6D));
Review Comment:
Why do we need to rename these test properties?
##########
polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfiguration.java:
##########
@@ -21,32 +21,76 @@
import java.util.ArrayList;
import java.util.List;
import java.util.Optional;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+import java.util.stream.Stream;
import org.apache.polaris.core.context.CallContext;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
/**
- * An ABC for Polaris configurations that alter the service's behavior
+ * An ABC for Polaris configurations that alter the service's behavior TODO:
deprecate unsafe
+ * catalog configs and remove related code
*
* @param <T> The type of the configuration
*/
public abstract class PolarisConfiguration<T> {
private static final Logger LOGGER =
LoggerFactory.getLogger(PolarisConfiguration.class);
+ public static final List<PolarisConfiguration<?>> allConfigurations = new
ArrayList<>();
Review Comment:
Since the list is mutable, could we keep it `private`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
