eric-maynard commented on code in PR #1557:
URL: https://github.com/apache/polaris/pull/1557#discussion_r2082985220
##########
quarkus/service/src/test/java/org/apache/polaris/service/quarkus/admin/PolarisOverlappingTableTest.java:
##########
@@ -79,15 +79,15 @@ static Stream<Arguments> testTableLocationRestrictions() {
"ALLOW_UNSTRUCTURED_TABLE_LOCATION", "false",
"ALLOW_TABLE_LOCATION_OVERLAP", "false");
Map<String, Object> laxCatalog =
Map.of(
- ALLOW_UNSTRUCTURED_TABLE_LOCATION.catalogConfig(),
+ ALLOW_UNSTRUCTURED_TABLE_LOCATION.catalogConfigs().getFirst(),
"true",
- ALLOW_TABLE_LOCATION_OVERLAP.catalogConfig(),
+ ALLOW_TABLE_LOCATION_OVERLAP.catalogConfigs().getFirst(),
Review Comment:
I think you're right to point out how awkward `catalogConfigs().getFirst()`
is, but in the current implementation it's not really clear which catalog
config is meant to be the "canonical name". There's a deeper problem here, let
me try to adjust the way we track the safe / unsafe configs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
