eric-maynard commented on code in PR #1572:
URL: https://github.com/apache/polaris/pull/1572#discussion_r2085674165
##########
quarkus/service/src/main/java/org/apache/polaris/service/quarkus/config/QuarkusFeaturesConfiguration.java:
##########
@@ -19,15 +19,23 @@
package org.apache.polaris.service.quarkus.config;
import io.smallrye.config.ConfigMapping;
+import io.smallrye.config.WithParentName;
import java.util.Map;
import org.apache.polaris.service.config.FeaturesConfiguration;
@ConfigMapping(prefix = "polaris.features")
public interface QuarkusFeaturesConfiguration extends FeaturesConfiguration {
+ @WithParentName
@Override
Map<String, String> defaults();
Review Comment:
I see the same thing, thanks for highlighting this. One doubt I have is
this: if we assume config names can't contain a dot, is the current behavior
okay? Since `realm-overrides."realm1"."ALLOW_SPECIFYING_FILE_IO_IMPL=false`
cannot be misinterpreted as the config value
`"realm1"."ALLOW_SPECIFYING_FILE_IO_IMPL`
Also, either way I can add some code enforcing that config keys don't
contain a dot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
