adutra commented on code in PR #1572:
URL: https://github.com/apache/polaris/pull/1572#discussion_r2085466287


##########
quarkus/service/src/main/java/org/apache/polaris/service/quarkus/config/QuarkusFeaturesConfiguration.java:
##########
@@ -28,6 +29,13 @@ public interface QuarkusFeaturesConfiguration extends 
FeaturesConfiguration {
   @Override
   Map<String, String> defaults();
 
+  @WithParentName

Review Comment:
   Well it _might_ be able to differentiate by the number of available path 
segments, e.g. the two lines below are (at least for us humans) unambiguously 
defined to be a default for the first one, and an override for the second one:
   
   ```properties
   polaris.features.INITIALIZE_DEFAULT_CATALOG_FILEIO_FOR_TEST"=true
   
polaris.features."my-realm"."INITIALIZE_DEFAULT_CATALOG_FILEIO_FOR_TEST"=false
   ```
   
   But I agree that it may be a bit risky to let a machine figure this subtlety 
out.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to