singhpk234 commented on code in PR #1482:
URL: https://github.com/apache/polaris/pull/1482#discussion_r2067688330
##########
extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/JdbcBasePersistenceImpl.java:
##########
@@ -315,6 +315,12 @@ private PolarisBaseEntity getPolarisBaseEntity(String
query) {
return results.getFirst();
}
} catch (SQLException e) {
+ // This look-up is used for checking if the realm is bootstrap or not.
+ // If we have 1 DB per realm it might happen that the realm is not
boostrap
+ // at all.
Review Comment:
yes entity null would mean entity not found and this would prompt bootstrap
which inturn would run the bootstrap script. Otherwise RTE here is everything
broken, i agree this is not an ideal but this is something we have from
persistence we expect EntityResult
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
