singhpk234 commented on code in PR #1482:
URL: https://github.com/apache/polaris/pull/1482#discussion_r2067505748
##########
quarkus/admin/src/main/java/org/apache/polaris/admintool/config/QuarkusProducers.java:
##########
@@ -76,4 +81,9 @@ public PolarisConfigurationStore configurationStore() {
// A configuration store is not required when running the admin tool.
return new PolarisConfigurationStore() {};
}
+
+ @Produces
+ public JdbcDatasource jdbcDatasource(@ConfigProperty(name =
"polaris.persistence.realm.isolation.type") String realmIsolationType, @All
List<InstanceHandle<DataSource>> dataSources) {
Review Comment:
sounds fair, i think being explicit would be really helpful, so i am also +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
