MonkeyCanCode commented on PR #1474:
URL: https://github.com/apache/polaris/pull/1474#issuecomment-2840395822

   > Sorry for the delay in reviewing (I'll be able to respond to comments 
quicker though).
   > 
   > I do think that it would be better to integrate this into the sync tool 
(at the very least a standalone tool in the tool repo). The sync tool should 
already have a lot of the complexity and nuances implemented to make things 
easier (different modes such as overwrite, cascading drops, etc.).
   > 
   > It was also restructured to better support things like an import / export 
scenario after feedback from the [mailing 
list](https://lists.apache.org/thread/bpflv1plchbq63rll66z607d8jsngf5r).
   > 
   > Basically you'd just update some CLI options to be able to say your source 
is this setup yaml. And then you could create a `PolarisService` 
[here](https://github.com/apache/polaris-tools/blob/46fe5e057e617eecee4da41bc36791736e3c55de/polaris-synchronizer/cli/src/main/java/org/apache/polaris/tools/sync/polaris/SyncPolarisCommand.java#L134)
 of a different service type that can implement the interface by just using the 
file.
   
   All good @travis-bowen. Thanks for the confirmation. In that case, I will 
close this PR for now. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to