MonkeyCanCode commented on PR #1474: URL: https://github.com/apache/polaris/pull/1474#issuecomment-2836958208
> This is a super cool idea - I really like this ability to add the setup to a configuration file! A few questions/comments from me below. > > But one thing I'd like to point out is in the `command/setup.py` file, there's quite a bit of code that could be made DRY by parameterizing what is being required (such as entity general validations and API call scaffoldings, amongst other things). I'd personally like to see some refactoring, which will add significantly to the maintainability and readability of the script. I understand that will not be possible for all entities or functions, but most entities are affected by this comment. For sure. This is more likes POC code to answer couple questions from community around how they can spin up x number of entities for their setup as the current CLI can only do one at a time and custom code is needed to support those. What I have locally is a bash script wrapper to invoke the CLI. While tried to share that bash script, I ended up writing this one as a new command last weekend. Before I spend time on refactor, I think we should check if this utility has overlap with sycn tool @eric-maynard refs to and see where we would want to head for those tooling. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
