dimas-b commented on code in PR #1371:
URL: https://github.com/apache/polaris/pull/1371#discussion_r2060956603


##########
quarkus/admin/src/main/java/org/apache/polaris/admintool/config/QuarkusProducers.java:
##########
@@ -76,4 +81,13 @@ public PolarisConfigurationStore configurationStore() {
     // A configuration store is not required when running the admin tool.
     return new PolarisConfigurationStore() {};
   }
+
+  @Produces
+  public List<DataSource> dataSources(@All List<InstanceHandle<DataSource>> 
dataSources) {

Review Comment:
   Please update `JdbcMetaStoreManagerFactory` to require one `DataSource` in 
the constructor (it only needs one anyway). Then, this producer will not be 
required.
   
   Let's deal with multiple Data Sources later.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to