singhpk234 commented on code in PR #1371:
URL: https://github.com/apache/polaris/pull/1371#discussion_r2060649675
##########
extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/JdbcBasePersistenceImpl.java:
##########
@@ -112,13 +161,12 @@ public void writeEntity(
originalEntity.getEntityVersion(),
"realm_id",
realmId);
- query = generateUpdateQuery(modelEntity, params);
try {
- int rowsUpdated = datasourceOperations.executeUpdate(query);
+ int rowsUpdated = execute(executor, generateUpdateQuery(modelEntity,
params));
if (rowsUpdated == 0) {
throw new RetryOnConcurrencyException(
"Entity '%s' id '%s' concurrently modified; expected version %s",
- entity.getName(), entity.getId(),
originalEntity.getEntityVersion());
+ originalEntity.getName(), originalEntity.getId(),
originalEntity.getEntityVersion());
}
} catch (SQLException e) {
Review Comment:
if we have originalEntity then this means that all the contraints PK as well
as subType match original and new entity version so we should be good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
