eric-maynard commented on code in PR #1378:
URL: https://github.com/apache/polaris/pull/1378#discussion_r2047908842
##########
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##########
@@ -1184,16 +1197,19 @@ public ViewBuilder withLocation(String newLocation) {
}
}
- private class BasePolarisTableOperations extends
BaseMetastoreTableOperations {
+ public class BasePolarisTableOperations extends BaseMetastoreTableOperations
{
private final TableIdentifier tableIdentifier;
private final String fullTableName;
+ private final boolean updateMetadataOnCommit;
private FileIO tableFileIO;
- BasePolarisTableOperations(FileIO defaultFileIO, TableIdentifier
tableIdentifier) {
+ BasePolarisTableOperations(
+ FileIO defaultFileIO, TableIdentifier tableIdentifier, boolean
updateMetadataOnCommit) {
LOGGER.debug("new BasePolarisTableOperations for {}", tableIdentifier);
this.tableIdentifier = tableIdentifier;
this.fullTableName = fullTableName(catalogName, tableIdentifier);
this.tableFileIO = defaultFileIO;
+ this.updateMetadataOnCommit = updateMetadataOnCommit;
Review Comment:
In the current iteration of the PR I'm making a judgement call between the
complexity of the change and consistency across views & tables. Ideally we can
contribute this upstream to Iceberg and then the reflection hack goes away. In
the meantime, views tend to have much less metadata than tables (and also to
get updated less frequently) and so I'm less concerned about the extra round
trip to object storage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
