collado-mike commented on code in PR #1378:
URL: https://github.com/apache/polaris/pull/1378#discussion_r2047895695
##########
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##########
@@ -1328,6 +1346,41 @@ public void doCommit(TableMetadata base, TableMetadata
metadata) {
String newLocation = writeNewMetadataIfRequired(base == null, metadata);
String oldLocation = base == null ? null : base.metadataFileLocation();
+ // TODO: we should not need to do this hack, but there's no other way to
modify
+ // currentMetadata / currentMetadataLocation
Review Comment:
Can't we add a `Map<String, TableMetadata>` to the `IcebergCatalog` and
access it from inside the `BasePolarisTableOperations`? The `IcebergCatalog` is
created for every request, so the map isn't long-lived, but it will be there
between the commit and the refresh. I don't see a need for the reflection below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
