eric-maynard commented on code in PR #1356:
URL: https://github.com/apache/polaris/pull/1356#discussion_r2042858385
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/MetaStoreManagerFactory.java:
##########
@@ -34,9 +35,11 @@ public interface MetaStoreManagerFactory {
Supplier<? extends BasePersistence> getOrCreateSessionSupplier(RealmContext
realmContext);
- StorageCredentialCache getOrCreateStorageCredentialCache(RealmContext
realmContext);
+ StorageCredentialCache getOrCreateStorageCredentialCache(
+ RealmContext realmContext, PolarisCallContext polarisCallContext);
- EntityCache getOrCreateEntityCache(RealmContext realmContext);
+ EntityCache getOrCreateEntityCache(
+ RealmContext realmContext, PolarisCallContext polarisCallContext);
Review Comment:
This is a good callout. In general I agree that we can leverage CDI to
inject context parameters (e.g. PolarisCallContext) around. However in this
particular case, the EntityCache is not a CDI-managed class. There's a
discussion above about this too, but I think we need a way to have configs that
are not tied to a PolarisCallContext('s configuration store).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
