dimas-b commented on code in PR #1356:
URL: https://github.com/apache/polaris/pull/1356#discussion_r2042813624
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/MetaStoreManagerFactory.java:
##########
@@ -34,9 +35,11 @@ public interface MetaStoreManagerFactory {
Supplier<? extends BasePersistence> getOrCreateSessionSupplier(RealmContext
realmContext);
- StorageCredentialCache getOrCreateStorageCredentialCache(RealmContext
realmContext);
+ StorageCredentialCache getOrCreateStorageCredentialCache(
+ RealmContext realmContext, PolarisCallContext polarisCallContext);
- EntityCache getOrCreateEntityCache(RealmContext realmContext);
+ EntityCache getOrCreateEntityCache(
+ RealmContext realmContext, PolarisCallContext polarisCallContext);
Review Comment:
I do not support passing context parameter as method args in general and
this PR adds another context parameter.
Could we leverage CDI for injecting context data?
##########
polaris-core/build.gradle.kts:
##########
@@ -36,6 +36,7 @@ dependencies {
implementation("com.fasterxml.jackson.core:jackson-annotations")
implementation("com.fasterxml.jackson.core:jackson-core")
implementation("com.fasterxml.jackson.core:jackson-databind")
+ implementation("jakarta.enterprise:jakarta.enterprise.cdi-api:4.1.0")
Review Comment:
Please use the `toml` file for version numbers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
