flyrain commented on code in PR #1330:
URL: https://github.com/apache/polaris/pull/1330#discussion_r2038833359
##########
build-logic/src/main/kotlin/publishing/configurePom.kt:
##########
@@ -103,7 +103,10 @@ internal fun configurePom(project: Project,
mavenPublication: MavenPublication,
connection.set("scm:git:$codeRepo")
developerConnection.set("scm:git:$codeRepo")
url.set("$codeRepo/tree/main")
- tag.set("main")
+ val version = project.version.toString()
+ if (!version.endsWith("-SNAPSHOT")) {
+ tag.set("apache-polaris-$version")
Review Comment:
I think the RCs are not published to maven repository. Taking this as an
example, https://mvnrepository.com/artifact/org.apache.iceberg/iceberg-core, we
can only see the formal ones, like 1.8.0, 1.8.1.
> @flyrain this has nothing to do with Git. It's the project version of the
build.
@snazy I'm confused by this statement, what do you mean by "nothing related
to git"? What does it tag in that case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
