snazy commented on code in PR #1330:
URL: https://github.com/apache/polaris/pull/1330#discussion_r2032530047
##########
build-logic/src/main/kotlin/publishing/configurePom.kt:
##########
@@ -103,7 +103,10 @@ internal fun configurePom(project: Project,
mavenPublication: MavenPublication,
connection.set("scm:git:$codeRepo")
developerConnection.set("scm:git:$codeRepo")
url.set("$codeRepo/tree/main")
- tag.set("main")
+ val version = project.version.toString()
+ if (!version.endsWith("-SNAPSHOT")) {
+ tag.set("apache-polaris-$version")
Review Comment:
@flyrain this has nothing to do with Git. It's the project version of the
build.
Changing an existing Git release tag is really bad practice.
BTW: we use Gradle, not Maven.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
