dimas-b commented on code in PR #1274: URL: https://github.com/apache/polaris/pull/1274#discussion_r2021976026
########## polaris-core/src/main/java/org/apache/polaris/core/persistence/BasePersistence.java: ########## @@ -37,6 +37,11 @@ * defining the internal data model for Polaris, and which defines the basis for the RBAC model * provided by Polaris. * + * <p>Each method in this interface must be atomic, meaning that write operations must either fully + * succeed with all changes applied, or fail entirely without any side effects or partial updates. Review Comment: I'd think that would be wrong in the scope of the `BasePersistence` interface. What I hinted at in my comment is that NoSQL implementations may leave unreachable stuff behind in case of failures (which naturally requires some amount of async maintenance). However, those stray entries will not be discoverable through the normal implementations of `BasePersistence` methods. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
