dimas-b commented on code in PR #1274: URL: https://github.com/apache/polaris/pull/1274#discussion_r2025238871
########## polaris-core/src/main/java/org/apache/polaris/core/persistence/BasePersistence.java: ########## @@ -37,6 +37,11 @@ * defining the internal data model for Polaris, and which defines the basis for the RBAC model * provided by Polaris. * + * <p>Each method in this interface must be atomic, meaning that write operations must either fully + * succeed with all changes applied, or fail entirely without partial updates. Read operations must + * provide a consistent snapshot of the data as it existed at the start of the operation, ensuring + * snapshot isolation. Review Comment: The definition from Wikipedia does not apply here given the reference to "at the start of the operation" earlier in the text... IMHO (note that `BasePersistence` does not define transactions). Thanks for the update. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
