[ 
https://issues.apache.org/jira/browse/OPENNLP-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17901851#comment-17901851
 ] 

ASF GitHub Bot commented on OPENNLP-1659:
-----------------------------------------

mawiesne commented on PR #697:
URL: https://github.com/apache/opennlp/pull/697#issuecomment-2507177315

   @rzo1 minor-isch conflict, pls rebase




> Improve DownloadUtil with several enhancements
> ----------------------------------------------
>
>                 Key: OPENNLP-1659
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-1659
>             Project: OpenNLP
>          Issue Type: Improvement
>            Reporter: Richard Zowalla
>            Assignee: Richard Zowalla
>            Priority: Major
>             Fix For: 2.5.1
>
>
> DownloadUtil has the need for some improvements:
>  * (1) Path handling is done without taking OS specific file separators into 
> account
>  * (2) Location of download cannot be configured
>  * (3) As soon as the classloader loads this class, a HTTP call is made to 
> parse download information, which might be bad, if we are in an offline 
> environment, etc.
>  * (4) There is no indication, if a model is downloaded multiple times. We 
> should at least log that situation and have a proper test case for it.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to