[
https://issues.apache.org/jira/browse/OPENNLP-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17901408#comment-17901408
]
ASF GitHub Bot commented on OPENNLP-1659:
-----------------------------------------
rzo1 opened a new pull request, #697:
URL: https://github.com/apache/opennlp/pull/697
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
clean install at the root opennlp folder?
- [x] Have you written or updated unit tests to verify your changes?
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file in opennlp folder?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found in opennlp folder?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
- Make the BASE_URL and MODEL_URI_PATH configurable via System properties in
order to be backwards compatible if models are removed from the release area of
OpenNLP / ASF CDN
- Make the OPENNLP_DOWNLOAD_HOME configurable, i.e. for tests in CI
environments. This can also be useful for OpenNLP devs to avoid cleaning models
in their user home.
- Replace hard coded file separators for multi OS support
- Log a DEBUG message if the model file already exists and the download is
skipped.
- Adds a test case to verify that models are not downloaded twice (if they
exist) by testing for the related LOG output using LogCaptor.
- Replaces slf4j-simple with logback (from LogCaptor) for further testing of
specific output
> Improve DownloadUtil with several enhancements
> ----------------------------------------------
>
> Key: OPENNLP-1659
> URL: https://issues.apache.org/jira/browse/OPENNLP-1659
> Project: OpenNLP
> Issue Type: Improvement
> Reporter: Richard Zowalla
> Assignee: Richard Zowalla
> Priority: Major
> Fix For: 2.5.1
>
>
> DownloadUtil has the need for some improvements:
> * (1) Path handling is done without taking OS specific file separators into
> account
> * (2) Location of download cannot be configured
> * (3) As soon as the classloader loads this class, a HTTP call is made to
> parse download information, which might be bad, if we are in an offline
> environment, etc.
> * (4) There is no indication, if a model is downloaded multiple times. We
> should at least log that situation and have a proper test case for it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
