lordgamez commented on code in PR #2128:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2128#discussion_r3014652985
##########
.github/workflows/verify-package.yml:
##########
@@ -11,16 +11,32 @@ on:
type: string
description: The id of the create-release-artifacts workflow to
download artifacts from
required: true
-
+ workflow_run:
+ workflows: ["Create Release Artifacts"]
+ types:
+ - completed
+ branches: [main]
env:
DOCKER_CMAKE_FLAGS: -DDOCKER_VERIFY_THREAD=3 -DUSE_SHARED_LIBS=
-DSTRICT_GSL_CHECKS=AUDIT -DCI_BUILD=ON -DENABLE_AWS=ON -DENABLE_KAFKA=ON
-DENABLE_MQTT=ON -DENABLE_AZURE=ON -DENABLE_SQL=ON \
-DENABLE_SPLUNK=ON -DENABLE_GCP=ON -DENABLE_OPC=ON
-DENABLE_PYTHON_SCRIPTING=ON -DENABLE_LUA_SCRIPTING=ON -DENABLE_KUBERNETES=ON
-DENABLE_TEST_PROCESSORS=ON -DENABLE_PROMETHEUS=ON \
-DENABLE_ELASTICSEARCH=OFF -DENABLE_GRAFANA_LOKI=ON -DENABLE_COUCHBASE=ON
-DDOCKER_BUILD_ONLY=ON
jobs:
+ check-artifacts-workflow:
+ name: "Check Create Release Artifacts status"
+ if: github.event_name == 'workflow_run'
+ runs-on: ubuntu-24.04
+ steps:
+ - name: Check workflow conclusion
+ if: github.event.workflow_run.conclusion != 'success'
+ run: |
+ echo "Create Release Artifacts workflow failed with conclusion: ${{
github.event.workflow_run.conclusion }}"
+ exit 1
docker-test-modular:
- name: "${{ matrix.platform.name }} (${{ matrix.arch }}) Modular${{
inputs.enable_fips && ' (FIPS Mode)' || '' }}"
+ name: "${{ matrix.platform.name }} (${{ matrix.arch }})${{
(github.event_name != 'workflow_dispatch' || inputs.enable_fips) && ' (FIPS
Mode)' || '' }}"
Review Comment:
I think it's better to use workflow_dispatch here as we want to keep the
same functionality for every event that is not workflow_dispatch if maybe other
kind of events are added in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
