Re: [PR] MINIFICPP-2737 Add weekly CI workflow runs and status page [nifi-minifi-cpp]

[via GitHub]

fgerlits commented on code in PR #2128:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2128#discussion_r2994060146


##########
docs/status/index.html:
##########


Review Comment:
   Is it possible to add a dark mode/light mode switch button (it's OK to keep 
the default as dark)? I know I'm in a minority on this, but I find it difficult 
to read low-contrast text.



##########
README.md:
##########
@@ -15,7 +15,7 @@
 
 [<img src="https://nifi.apache.org/assets/images/minifi/minifi-logo.svg"; 
width="300" height="126" alt="Apache NiFi 
MiNiFi"/>](https://nifi.apache.org/minifi/)
 
-# Apache NiFi -  MiNiFi - C++ [![MiNiFi-CPP 
CI](https://github.com/apache/nifi-minifi-cpp/actions/workflows/ci.yml/badge.svg?branch=main)](https://github.com/apache/nifi-minifi-cpp/actions/workflows/ci.yml?query=workflow%3A%22MiNiFi-CPP+CI%22+branch%3Amain)
+# Apache NiFi -  MiNiFi - C++ [![MiNiFi-CPP 
CI](https://github.com/apache/nifi-minifi-cpp/actions/workflows/ci.yml/badge.svg?branch=main)](https://github.com/apache/nifi-minifi-cpp/actions/workflows/ci.yml?query=workflow%3A%22MiNiFi-CPP+CI%22+branch%3Amain)[![Check
 Supported 
Compilers](https://github.com/apache/nifi-minifi-cpp/actions/workflows/compiler-support.yml/badge.svg?branch=main)](https://github.com/apache/nifi-minifi-cpp/actions/workflows/compiler-support.yml?query=branch%3Amain)[![MiNiFi-CPP
 
Memcheck](https://github.com/apache/nifi-minifi-cpp/actions/workflows/memcheck_ci.yml/badge.svg?branch=main)](https://github.com/apache/nifi-minifi-cpp/actions/workflows/memcheck_ci.yml?query=branch%3Amain)[![MiNiFi-CPP
 Verify 
Package](https://github.com/apache/nifi-minifi-cpp/actions/workflows/verify-package.yml/badge.svg?branch=main)](https://github.com/apache/nifi-minifi-cpp/actions/workflows/verify-package.yml?query=branch%3Amain)[![Status
 Page](https://img.shields.io/website?url=h
 
ttps%3A%2F%2Fapache.github.io%2Fnifi-minifi-cpp%2Fstatus%2F&label=Status%20Page)](https://apache.github.io/nifi-minifi-cpp/status/)

Review Comment:
   this will be a very long line; maybe move the badges to below the title, one 
badge per line?



##########
.github/workflows/verify-package.yml:
##########
@@ -11,16 +11,32 @@ on:
         type: string
         description: The id of the create-release-artifacts workflow to 
download artifacts from
         required: true
-
+  workflow_run:
+    workflows: ["Create Release Artifacts"]
+    types:
+      - completed
+    branches: [main]
 
 env:
   DOCKER_CMAKE_FLAGS: -DDOCKER_VERIFY_THREAD=3 -DUSE_SHARED_LIBS= 
-DSTRICT_GSL_CHECKS=AUDIT -DCI_BUILD=ON -DENABLE_AWS=ON -DENABLE_KAFKA=ON 
-DENABLE_MQTT=ON -DENABLE_AZURE=ON -DENABLE_SQL=ON \
     -DENABLE_SPLUNK=ON -DENABLE_GCP=ON -DENABLE_OPC=ON 
-DENABLE_PYTHON_SCRIPTING=ON -DENABLE_LUA_SCRIPTING=ON -DENABLE_KUBERNETES=ON 
-DENABLE_TEST_PROCESSORS=ON -DENABLE_PROMETHEUS=ON \
     -DENABLE_ELASTICSEARCH=OFF -DENABLE_GRAFANA_LOKI=ON -DENABLE_COUCHBASE=ON 
-DDOCKER_BUILD_ONLY=ON
 
 jobs:
+  check-artifacts-workflow:
+    name: "Check Create Release Artifacts status"
+    if: github.event_name == 'workflow_run'
+    runs-on: ubuntu-24.04
+    steps:
+      - name: Check workflow conclusion
+        if: github.event.workflow_run.conclusion != 'success'
+        run: |
+          echo "Create Release Artifacts workflow failed with conclusion: ${{ 
github.event.workflow_run.conclusion }}"
+          exit 1
   docker-test-modular:
-    name: "${{ matrix.platform.name }} (${{ matrix.arch }}) Modular${{ 
inputs.enable_fips && ' (FIPS Mode)' || '' }}"
+    name: "${{ matrix.platform.name }} (${{ matrix.arch }})${{ 
(github.event_name != 'workflow_dispatch' || inputs.enable_fips) && ' (FIPS 
Mode)' || '' }}"

Review Comment:
   nitpicking, but why not
   ```suggestion
       name: "${{ matrix.platform.name }} (${{ matrix.arch }})${{ 
(github.event_name == 'workflow_run' || inputs.enable_fips) && ' (FIPS Mode)' 
|| '' }}"
   ```
   ?
   
   (also in lines 93 and 104)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org