martinzink commented on code in PR #2142:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2142#discussion_r3000615462


##########
.github/workflows/ci.yml:
##########
@@ -170,37 +170,32 @@ jobs:
       - name: Support longpaths
         run: git config --system core.longpaths true
       - name: Checkout project
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
       - name: Restore cache
-        uses: actions/cache/restore@v4
+        uses: actions/cache/restore@v5
         with:
           path: ~/AppData/Local/Mozilla/sccache/cache
           key: ${{ runner.os }}-2022-sccache-${{ github.ref }}-${{ github.sha 
}}
           restore-keys: |
             ${{ runner.os }}-2022-sccache-${{ github.ref }}
             ${{ runner.os }}-2022-sccache-refs/heads/main
             ${{ runner.os }}-2022-sccache
-      - name: Run sccache-cache
-        uses: 
mozilla-actions/sccache-action@7d986dd989559c6ecdb630a3fd2557667be217ad  # 
v0.0.9
       - name: Set up Python
-        run: choco -y install python & refreshenv
+        run: choco install -y python sccache & refreshenv

Review Comment:
   ive reworked a bit the cache strategy it should be better than before 
(previously it had conflicting caches it used both SCCACHE_GHA_ENABLE and 
cache/restore cache/save which from what i read might not be what we wanted) 
   
   last build was 58m 28s



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to