martinzink commented on code in PR #2142:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2142#discussion_r3000603915


##########
.github/workflows/ci.yml:
##########
@@ -170,37 +170,32 @@ jobs:
       - name: Support longpaths
         run: git config --system core.longpaths true
       - name: Checkout project
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
       - name: Restore cache
-        uses: actions/cache/restore@v4
+        uses: actions/cache/restore@v5
         with:
           path: ~/AppData/Local/Mozilla/sccache/cache
           key: ${{ runner.os }}-2022-sccache-${{ github.ref }}-${{ github.sha 
}}
           restore-keys: |
             ${{ runner.os }}-2022-sccache-${{ github.ref }}
             ${{ runner.os }}-2022-sccache-refs/heads/main
             ${{ runner.os }}-2022-sccache
-      - name: Run sccache-cache
-        uses: 
mozilla-actions/sccache-action@7d986dd989559c6ecdb630a3fd2557667be217ad  # 
v0.0.9
       - name: Set up Python
-        run: choco -y install python & refreshenv
+        run: choco install -y python sccache & refreshenv

Review Comment:
   it gets used, 
https://github.com/apache/nifi-minifi-cpp/actions/runs/23640764731/job/68860613100?pr=2142
   
   > Run sccache --show-stats
   Compile requests                   4454
   Compile requests executed          4454
   Cache hits                         4422
   Cache hits (C/C++)                 4422
   Cache misses                         32
   Cache misses (C/C++)                 32
   Cache hits rate                   99.28 %
   Cache hits rate (C/C++)           99.28 %
   Cache timeouts                        0
   Cache read errors                     0
   Forced recaches                       0
   Cache write errors                    0
   Cache errors                          0
   Compilations                         32
   Compilation failures                  0
   Non-cacheable compilations            0
   Non-cacheable calls                   0
   Non-compilation calls                 0
   Unsupported compiler calls            0
   Average cache write               0.003 s
   Average compiler                  1.083 s
   Average cache read hit            0.006 s
   Failed distributed compilations       0
   Cache location                  Local disk: 
"C:\\Users\\runneradmin\\AppData\\Local\\Mozilla\\sccache\\cache"
   Base directories                (none)
   Use direct/preprocessor mode?   yes
   Version (client)                0.14.0
   Cache size                          183 MiB
   Max cache size                       10 GiB



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to