fgerlits commented on code in PR #2145:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2145#discussion_r2994630587
##########
behave_framework/pyproject.toml:
##########
@@ -15,4 +15,7 @@ dependencies = [
[tool.setuptools]
package-dir = {"" = "src"}
-packages = ["minifi_test_framework"]
+
+[tool.setuptools.packages.find]
+where = ["src"]
+include = ["minifi_test_framework*"]
Review Comment:
this will conflict (in a way not detected by git) with #2146
##########
.github/workflows/create-release-artifacts.yml:
##########
@@ -40,3 +40,65 @@ jobs:
with:
name: ${{ matrix.platform.rpm-artifact }}
path: build/nifi-minifi-cpp-*.rpm
+ windows_VS2022:
+ name: "Windows Server 2025 x86_64"
+ runs-on: windows-2025
+ timeout-minutes: 240
+ steps:
+ - name: Support longpaths
+ run: git config --system core.longpaths true
+ - name: Checkout project
+ uses: actions/checkout@v4
+ - name: Set up Python
+ run: choco -y install python & refreshenv
+ shell: cmd
+ - name: Install sqliteodbc driver
+ run: |
+ Invoke-WebRequest -Uri
"http://www.ch-werner.de/sqliteodbc/sqliteodbc_w64.exe"; -OutFile
"sqliteodbc_w64.exe"
+ if ((Get-FileHash 'sqliteodbc_w64.exe').Hash -ne
"a4804e4f54f42c721df1323c5fcac101a8c7a577e7f20979227324ceab572d51") {Write
"Hash mismatch"; Exit 1}
+ Start-Process -FilePath ".\sqliteodbc_w64.exe" -ArgumentList "/S"
-Wait
+ shell: powershell
+ - name: build
+ run: |
+ python -m venv venv && venv\Scripts\activate && pip install -r
requirements.txt & python main.py --noninteractive --skip-compiler-install
--minifi-options="-DCMAKE_BUILD_TYPE=Release -DCI_BUILD=OFF -DENABLE_ALL=ON
-DMINIFI_FAIL_ON_WARNINGS=OFF -DSKIP_TESTS=ON"
Review Comment:
Why is the third command separator a &? If & is non-shortcircuiting, I would
use && there, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
