martinzink commented on code in PR #2145:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2145#discussion_r2993922116
##########
extensions/sftp/tests/tools/SFTPTestServer.cpp:
##########
@@ -138,10 +138,10 @@ bool SFTPTestServer::stop() {
logger_->log_debug("Deleting port file {}", port_file_path_);
::unlink(port_file_path_.c_str());
}
-#endif
server_pid_ = -1;
Review Comment:
It still has compile issues. I've checked and we dont enable SFTP on windows
CI job, and locally it skips the tests if java or maven is missing, thats why
it could fly under our radar.
Since this would require a bigger effort, this is not the PR to fix these
I've created a new jira for this effort, and disabled tests for this job (we
dont run tests anyway in these jobs so it makes sense to skip them here)
https://issues.apache.org/jira/browse/MINIFICPP-2759
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
