[ https://jira.codehaus.org/browse/MASSEMBLY-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=358714#comment-358714 ]
Jean-Eric Cuendet commented on MASSEMBLY-743: --------------------------------------------- After analysis, the value set between the <includeBaseDirectory> tag, ${min.includeBaseDirectory} is converted in Boolean while reading the assembly descriptor. Since it's not a valid boolean value, it's transformed to the default value : false The resolution of variables into values is done after the assembly descriptor reading. And at that moment the variable is lost. To correct, there is 2 way: 1. In the Assembly class, have 2 values, one as String containing the variable, another Boolean value containing the resolved value 2. Resolve the variables to values while reading the assembly descriptor. Which one do you prefer? I can try to correct that one and post a patche if you give some guidance. > <includeBaseDirectory> not correct > ---------------------------------- > > Key: MASSEMBLY-743 > URL: https://jira.codehaus.org/browse/MASSEMBLY-743 > Project: Maven Assembly Plugin > Issue Type: Bug > Affects Versions: 2.5.2 > Reporter: Jean-Eric Cuendet > Assignee: Kristian Rosenvold > Fix For: 2.5.3 > > Attachments: maven-assembly-bug.tar.gz > > > I use the assembly plugin, with the <includeBaseDirectory> tag in the > assembly.xml file. If I put a variable (${mine.includeBaseDirectory}) in the > tag, it's not taken into account. > But if I use true or false, that fine. > I have created a small project that shows the problem. It's attached. > To reproduce: > - unzip the attachment > - cd maven-assembly-bug/ > - mvn clean install assembly:single > The file maven-assembly-bug-1.0.0-SNAPSHOT.tar.gz doesn't contain the > baseDir, while the variable used in the <includeBaseDirectory> tag is set to > true > If you change the value in assembly.xml to true or false (instead of using > the variable), that's worting fine. -- This message was sent by Atlassian JIRA (v6.1.6#6162)