[ 
https://jira.codehaus.org/browse/MASSEMBLY-357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kristian Rosenvold closed MASSEMBLY-357.
----------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.5.1
         Assignee: Kristian Rosenvold

This has been fixed in 2.5.1 since individual dependency sets now are seaparate 
resolution requests

> transitive dependencies erroneously excluded from dependencySet in some cases
> -----------------------------------------------------------------------------
>
>                 Key: MASSEMBLY-357
>                 URL: https://jira.codehaus.org/browse/MASSEMBLY-357
>             Project: Maven Assembly Plugin
>          Issue Type: Bug
>          Components: dependencySet
>    Affects Versions: 2.2-beta-2
>            Reporter: John Casey
>            Assignee: Kristian Rosenvold
>             Fix For: 2.5.1
>
>
> Given the following dependencies in a POM:
> {code:xml}
> <dependency>
>   <groupId>commons-codec</groupId>
>   <artifactId>commons-codec</artifactId>
>   <version>1.3</version>
> </dependency>
> <dependency>
>   <groupId>commons-httpclient</groupId>
>   <artifactId>commons-httpclient</artifactId>
>   <version>3.1</version>
> </dependency>
> {code}
> ..and the following assembly descriptor snippet:
> {code:xml}
>     <dependencySet>
>       <includes>
>         <include>commons-codec*</include>
>       </includes>
>       <outputDirectory>codec</outputDirectory>
>       <unpack>false</unpack>
>       <useTransitiveDependencies>true</useTransitiveDependencies>
>     </dependencySet>
>     <dependencySet>
>       <includes>
>         <include>commons-httpclient*</include>
>       </includes>
>       <outputDirectory>httpclient</outputDirectory>
>       <useTransitiveDependencies>true</useTransitiveDependencies>
>       <useTransitiveFiltering>true</useTransitiveFiltering>
>       <unpack>false</unpack>
>     </dependencySet>
> {code}
> commons-codec *should* wind up in both the codec and httpclient dirs, but 
> it's only in the codec dir. The reason for this is found in the 
> maven-artifact code used to resolve dependencies. Since commons-codec is 
> present as a direct dependency, it's *removed* from the sub-tree rooted by 
> commons-httpclient, and its dependency trail doesn't contain even a whisper 
> of this sub-tree structure. Since the transitive inclusions in dependencySets 
> are calculated using artifact identifications (dependencyConflictId and id 
> itself), along with the dependency trail it contains, the assembly plugin 
> can't see the association between commons-httpclient and commons-codec, 
> resulting in incomplete filtering for the dependencySet.



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)

Reply via email to