[
https://jira.codehaus.org/browse/MPIR-279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=355436#comment-355436
]
Michael Osipov edited comment on MPIR-279 at 11/2/14 12:48 PM:
---------------------------------------------------------------
Hi folks,
I have a working patch for the issue. I tried to make the logic as good as in
{{<menu ref="modules">}}. Therefore, I have borrowed from {{DefaultSiteTool}}.
This isn't ideal because it duplicates code. Can be resolved with a new ticket.
The other issue is that I have to inject {{@Component protected
MavenProjectBuilder mavenProjectBuilder}} but tests fail because it is not
injected. Normal execution works. Maybe someone can take a look at it. A code
review would be highly appreciated.
Here is the branch for that:
https://svn.apache.org/repos/asf/maven/plugins/branches/MPIR-279
ViewVC: http://svn.apache.org/r1636164
SNAPSHOT has been deployed.
Here are the generated sites for the attached project and Surefire from master:
OG-Platform2: http://people.apache.org/~michaelo/MPIR-279/OG-Platform2/
Maven Surefire: http://people.apache.org/~michaelo/MPIR-279/maven-surefire/
Please test and review, especially the issue with the failing test case.
was (Author: michael-o):
Hi folks,
I have a working patch for the issue. I tried to make the logic as good as in
{{<menu ref="modules">}}. Therefore, I have borrowed from {{DefaultSiteTool}}.
This isn't ideal because it duplicates code. Can be filed in a new ticket. The
other issue is that I have to inject {{@Component protected
MavenProjectBuilder mavenProjectBuilder}} but tests fail because it is not
injected. Normal execution works. Maybe someone can take a look at it. A code
review would be highly appreciated.
Here is the branch for that:
https://svn.apache.org/repos/asf/maven/plugins/branches/MPIR-279
ViewVC: http://svn.apache.org/r1636164
SNAPSHOT has been deployed.
Here are the generated sites for the attached project and Surefire from master:
OG-Platform2: http://people.apache.org/~michaelo/MPIR-279/OG-Platform2/
Maven Surefire: http://people.apache.org/~michaelo/MPIR-279/maven-surefire/
Please test and review, especially the issue with the failing test case.
> Wrong hyperlinks on index and modules page
> ------------------------------------------
>
> Key: MPIR-279
> URL: https://jira.codehaus.org/browse/MPIR-279
> Project: Maven Project Info Reports Plugin
> Issue Type: Bug
> Components: modules
> Affects Versions: 2.7
> Reporter: Stephen Colebourne
> Assignee: Michael Osipov
> Attachments: OG-Platform2.zip
>
>
> The attached zip is a complete multi-module build with the bug exposed. Run
> using "mvn clean site site:stage" to reproduce.
> What is observed is that the navigation hyperlinks in the top left (added by
> the site plugin) are correctly defined as
> "target/staging/og-timeseries/index.html", whereas the hyperlinks in the
> middle of index.html and modules.html are incorrectly defined as
> "target/staging/projects/og-timeseries/index.html" - note the incorrect extra
> "projects".
> The problem will occur because the child projects in the multi-module build
> are not immediate children of the parent/aggregator. Instead the structure is:
> {code}
> platform
> - pom.xml
> - projects
> - og-timeseries
> - pom.xml
> {code}
> The extra layer is being handled by the site plugin (by referring to the
> "distributionManagement.site.url"). It is not handled by this plugin.
> As a side note, if "distributionManagement.site.url" is NOT set in the child
> projects, then the site will build consistently using
> "target/staging/projects/og-timeseries/index.html" everywhere.
> This is no doubt related to MPIR-273.
--
This message was sent by Atlassian JIRA
(v6.1.6#6162)
