[
https://jira.codehaus.org/browse/SUREFIRE-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=354700#comment-354700
]
Andrew Phillips commented on SUREFIRE-654:
------------------------------------------
Unfortunately, this patch doesn't seem to work for me :-( What I did:
1. Cloned the surefire project
2. Reverted to the 2.17 release commit and applied the patch
3. Built and installed the surefire plugin locally (version 2.17-SUREFIRE-654)
4. Ran the attached project with {{mvn clean test}}
The test should fail as all four invocations fail, but even with a success
percentage of 99% the build succeeds. See attached output.
My environment:
Apache Maven 3.2.1 (ea8b2b07643dbb1b84b6d16e1f08391b666bc1e9;
2014-02-14T12:37:52-05:00)
Maven home: C:\Program Files (x86)\Apache\maven-3.2.1\bin\..
Java version: 1.7.0_40, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.7.0_40\jre
Default locale: en_GB, platform encoding: Cp1252
OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
> Surefire does not recognize successful tests using TestNG with the
> invocationCount and successPercentage parameters on the @Test annotation
> -------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: SUREFIRE-654
> URL: https://jira.codehaus.org/browse/SUREFIRE-654
> Project: Maven Surefire
> Issue Type: Bug
> Components: TestNG support
> Affects Versions: 2.6
> Environment: Apache Maven 2.2.1 (rdebian-4)
> Java version: 1.6.0-18
> Java home: /usr/lib/jvm/java-6-openjdk/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux" version: "2.6.35-22-generic" arch: "amd64" Family: "unix"
> Ubuntu 10.10
> Reporter: Steve Stodola
> Attachments: bugtest.tar.gz, surefire654.diff,
> surefire-fix-test-build-output.txt, surefire-fix-test.zip
>
>
> Surefire does not recognize successful tests using TestNG with the
> invocationCount and successPercentage parameters on the @Test annotation.
> BugTest.java in the attached file has an invocationCount = 100 with a
> successPercentage = 1. 1 test in 100 needs to pass for the test to be
> considered successful. However when running *{{mvn clean test}}* Surefire
> reports the tests as failed. The generated report shows the tests as passing.
> Surefire should be identifying this test as passing.
--
This message was sent by Atlassian JIRA
(v6.1.6#6162)
