[
https://jira.codehaus.org/browse/SCM-762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=348975#comment-348975
]
Dan Tran commented on SCM-762:
------------------------------
In order to do full validation, there is a need to use File.getCannonicalPath()
which forces the construction to add IOException throws clause. It is not
desirable since it break the api.
> Validate ScmFileSet's external filelist agrument
> ------------------------------------------------
>
> Key: SCM-762
> URL: https://jira.codehaus.org/browse/SCM-762
> Project: Maven SCM
> Issue Type: Improvement
> Components: maven-scm-api
> Affects Versions: 1.9
> Reporter: Dan Tran
> Assignee: Dan Tran
> Fix For: 1.10
>
>
> ScmFileSet has this public method
> {code}
> /**
> * Create a file set with the files provided, relative to basedir.
> *
> * @param basedir directory files are relative to
> * @param files list of File objects, files that the set will contain,
> have to be relative to basedir
> */
> public ScmFileSet( File basedir, List<File> files )
> {
> ....
> }
> However, passing 'files' argument is not validated for its contract. without
> that, the exception get thrown at very deep into provider and harder to
> understand
> {code>
--
This message was sent by Atlassian JIRA
(v6.1.6#6162)
