[
https://jira.codehaus.org/browse/MNG-5626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=345647#comment-345647
]
Michael Osipov commented on MNG-5626:
-------------------------------------
Hervé,
here are the spots:
{noformat}
maven-aether-provider/src/test/java/org/apache/maven/repository/internal/util/ConsoleTransferListener.java:
long duration = System.currentTimeMillis() -
resource.getTransferStartTime();
maven-compat/src/main/java/org/apache/maven/artifact/repository/metadata/DefaultRepositoryMetadataManager.java:
file.setLastModified( System.currentTimeMillis() );
maven-compat/src/main/java/org/apache/maven/repository/legacy/DefaultUpdateCheckManager.java:
props.setProperty( key, Long.toString(
System.currentTimeMillis() ) );
maven-compat/src/main/java/org/apache/maven/repository/legacy/DefaultWagonManager.java:
destination.setLastModified(
System.currentTimeMillis() );
maven-compat/src/main/java/org/apache/maven/repository/legacy/MavenArtifact.java:
this.transferStartTime = System.currentTimeMillis();
maven-compat/src/test/java/org/apache/maven/artifact/testutils/TestFileManager.java:
File dir = new File( TEMP_DIR_PATH, baseFilename +
System.currentTimeMillis() );
maven-compat/src/test/java/org/apache/maven/repository/legacy/StringWagon.java:
resource.setLastModified( System.currentTimeMillis() );
maven-core/src/main/java/org/apache/maven/artifact/repository/metadata/AbstractRepositoryMetadata.java:
metadataFile.setLastModified( System.currentTimeMillis() );
maven-core/src/main/java/org/apache/maven/lifecycle/internal/builder/BuilderCommon.java:
long buildEndTime = System.currentTimeMillis();
maven-core/src/main/java/org/apache/maven/lifecycle/internal/LifecycleModuleBuilder.java:
long buildStartTime = System.currentTimeMillis();
maven-core/src/main/java/org/apache/maven/lifecycle/internal/LifecycleModuleBuilder.java:
long buildEndTime = System.currentTimeMillis();
maven-core/src/test/java/org/apache/maven/project/DefaultMavenProjectBuilderTest.java:
localRepoDir = new File( System.getProperty( "java.io.tmpdir" ),
"local-repo." + System.currentTimeMillis() );
maven-core/src/test/java/org/apache/maven/project/MavenProjectTest.java:
new File( System.getProperty( "java.io.tmpdir" ), "maven-project-tests" +
System.currentTimeMillis()
maven-embedder/src/main/java/org/apache/maven/cli/event/ExecutionEventLogger.java:
long finish = System.currentTimeMillis();
maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java:
long duration = System.currentTimeMillis() -
resource.getTransferStartTime();
maven-embedder/src/main/java/org/apache/maven/cli/transfer/Slf4jMavenTransferListener.java:
long duration = System.currentTimeMillis() -
resource.getTransferStartTime();
{noformat}
Did I miss some?
> Avoid negative durations or handle them correctly
> -------------------------------------------------
>
> Key: MNG-5626
> URL: https://jira.codehaus.org/browse/MNG-5626
> Project: Maven 2 & 3
> Issue Type: Bug
> Components: Logging
> Affects Versions: 3.2.1
> Reporter: Christian Jung
> Priority: Minor
>
> In issue MNG-5623 we reported an exception when printing the reactor summary
> if one of the times was negative.
> I saw in one case, that the overall maven build time, as measured from
> outside (i.e. by our QuickBuild system) was -10.8 seconds. The corresponding
> reactor summary was:
> {code}
> 13:55:25,184 INFO - Reactor Summary:
> 13:55:25,184 INFO -
> 13:55:25,184 INFO - module1 ...........................................
> SUCCESS [ 5.911 s]
> 13:55:25,184 INFO - module2 ...........................................
> SUCCESS [ 0.255 s]
> 13:55:25,184 INFO - gpPlaygroundBase-lnx-x64-gcc4 .....................
> SUCCESS [-27.-64 s]
> 13:55:25,185 INFO -
> ------------------------------------------------------------------------
> 13:55:25,185 INFO - BUILD SUCCESS
> 13:55:25,185 INFO -
> ------------------------------------------------------------------------
> 13:55:25,185 INFO - Total time: -20.-73 s
> 13:55:25,185 INFO - Finished at: 2014-04-28T13:55:25+01:00
> 13:55:25,572 INFO - Final Memory: 32M/439M
> 13:55:25,572 INFO -
> ------------------------------------------------------------------------
> {code}
> The thing is quite hard to reproduce, the machines were virtual machines that
> have been running for quite a long time.
> Our administrators suspected that just at this point, the local clock was
> synchronized with some outer source.
> We should check if such negative durations can be avoided, and if not, they
> should be handled correctly.
--
This message was sent by Atlassian JIRA
(v6.1.6#6162)
