[
https://jira.codehaus.org/browse/MSHADE-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=343883#comment-343883
]
Robert Scholte commented on MSHADE-165:
---------------------------------------
Just a few remarks: I'm missing a junit-test and/or integration-test to confirm
your issue and that the patch fixes it. IMHO {{collectSellections}} is not
strong enough. You probably want to decide per shaded artifact which
manifestEntries should be added and which not.
> Allow collection of additional manifest sections in the shaded jar manifest
> ---------------------------------------------------------------------------
>
> Key: MSHADE-165
> URL: https://jira.codehaus.org/browse/MSHADE-165
> Project: Maven Shade Plugin
> Issue Type: Improvement
> Affects Versions: 2.2
> Reporter: Henning Schmiedehausen
>
> https://github.com/apache/maven-plugins/pull/18
> This change adds a flag to the ManifestResourceTransformer that will
> make it collect all additional manifest sections (non-main) and add
> them to the manifest of the shaded jar.
> This is useful if per-jar information is stored in Manifests
> (e.g. build information) and should still be present in the resulting
> shaded jar.
> If a section is present in one or more source jars, they are merged
> into a single section (TODO: add code to choose between "replace",
> "merge" or "fail").
--
This message was sent by Atlassian JIRA
(v6.1.6#6162)
